-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hf ingestion #483
base: main
Are you sure you want to change the base?
Hf ingestion #483
Conversation
return output | ||
|
||
|
||
def download_hf_dataset(local_cache_directory: str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this method support downloading all the popular HF Generative AI datasets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a great pr to see if we could abuse the new fsspec hf
fsspec system to start accessing files. we would just need to use fsspec open
and the related ls shims to navigate through the directories.
if not os.path.exists(directory): | ||
os.makedirs(directory) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not os.path.exists(directory): | |
os.makedirs(directory) | |
os.makedirs(directory, exist_ok=True) |
Description of changes:
Add a ingestion helper utility for Huggingface datasets downloading.
Building on snapshot_download, some improvements include
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)